@kwiesmueller: You must be a member of the kubernetes/website-milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Website milestone maintainers and have them propose you as an additional delegate for this responsibility.

@kwiesmueller: GitHub didn't allow me to request PR reviews from the following users: simplytunde.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

Deploy preview for kubernetes-io-vnext-staging processing.

Building with commit f6601f0

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5cffef7713e94d00071bb2c3

Please indicate if this is a WIP.

sorry @tengqm
yes it's wip for now.

/milestone 1.15

I think this is still relevant for 1.15. @kwiesmueller would you mind following-up on that?

Sure, I'll take care of it.

@apelisse I added another example for using JSONPatch. The PR should be ready for review by EOD today to still make it for 1.15. Can you think of any further things we should add here and get ready by this evening?

@kwiesmueller Perfect, its just that this KEP is targeted for 1.16 I think kubernetes/enhancements#555 (comment). Correct me if I am wrong. It did not make it to 1.15 release cut.
cc/ @apelisse for more information.

/hold

@makoscafee the feature we talk about is already in alpha since 1.14. This PR got added to address a question as part of our umbrella issue kubernetes/kubernetes#73723 to show people how to reset a field that got introduced in 1.14 (alpha).

So adding this is only related to the feature inside the KEP but directly targets the current release (1.15) on purpose.
The test proving the documentation added here works as intended got added here: kubernetes/kubernetes#77821

Thanks for clarification @kwiesmueller. Do you think will it be possible for it to be merged by today? we are behind schedule on getting all PR for this release merged.

Let me know if there is anything needed.

/hold clear

@apelisse would it be okay for you to merge this?
I think all other options (except apply) should work but couldn't test them yet. If we wan't to document all the options, I'd prefer having tests for them as well and then add them to the docs which won't happen in this release due to code freeze (i think).

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign jimangel
You can assign the PR to them by writing /assign @jimangel in a comment when ready.

The full list of commands accepted by this bot can be found here.

@apelisse I updated the PR and added this one for kubernetes/kubernetes#78912 verifying the docs work in all cases.

Thanks a lot Kevin, looking at it now (I ended-up in various meeting this morning so I couldn't exactly do it when I said I would)

/lgtm

@jimangel Did you mean /approve? :-)

One thing that is not super clear is ... what does it mean to strip all the managed fields? what about the operation that you're running as you clear?

Like.. what if I do:

PATCH /api/v1/namespaces/default/configmaps/example-cm
Content-Type: application/merge-patch+json
Accept: application/json
Data: {"metadata":{"managedFields": [{}]}, "other": "changes"}

What is managedField going to look like after this patch? Will it be empty or will it be me owning other?

I just tested this, seems like when you overwrite the managedFields in a request, this is the final operation. So in your example, the managedFields are empty.
We really got to document this, so I'll add it. But maybe we also should discuss if this is how we want it to behave?

I agree that seems like a bug to me.

Hi, @kwiesmueller and @apelisse so since this PR has some work to be done. and the deadline to have all PR passed since June 10th.I am going to strip it from 1.15 milestone and we can get it in as a fast follow -- retarget for master after the release, since we are publishing continuously from master.

/milestone clear

Closing this PR as it is referencing dev-1.15and the cycle has ended.